[Intel-gfx] [PULL] git-fixes for 4.16-rc2

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 22 07:19:54 UTC 2018


Quoting Zhenyu Wang (2018-02-22 03:13:19)
> On 2018.02.20 20:15:22 +0000, Chris Wilson wrote:
> > Quoting Zhenyu Wang (2018-02-14 05:28:27)
> > > 
> > > Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for
> > > chinese new year, team would take one week off at least, so like to
> > > send this out before vacation. This has one to fix GTT mmio 8b access
> > > from guest and two simple ones for mmio switch and typo fix. And sorry
> > > that patchwork link is still not there yet, using dim to pull should
> > > be ok but might need direct push to skip dim push check for now.
> > 
> > There are still quite a few sore points that would be nice to fix:
> > 
> > drivers/gpu/drm/i915/gvt/handlers.c:203 sanitize_fence_mmio_access()
> > error: 'vgpu' dereferencing possible ERR_PTR()
> > drivers/gpu/drm/i915/gvt/handlers.c:323 gdrst_mmio_write() warn:
> > inconsistent indenting
> > drivers/gpu/drm/i915/gvt/handlers.c:871 dp_aux_ch_ctl_mmio_write()
> > error: buffer overflow 'display->ports' 5 <= 5
> > drivers/gpu/drm/i915/gvt/handlers.c:1392 hws_pga_write() error: 'vgpu'
> > dereferencing possible ERR_PTR()
> > drivers/gpu/drm/i915/gvt/handlers.c:1402 hws_pga_write() error: 'vgpu'
> > dereferencing possible ERR_PTR()
> > 
> > + Lots of kerneldoc errors that should be tidied up.
> 
> Chris, thanks for this, we will double check those smatch warnings.
> 
> Strange thing is that 0day kernel does run kinds of static checker
> against our tree, but seems reports are sent to Dan instead of our
> developers...

Dan Carpenter is the developer behind smatch, and he runs and sends
reports himself. It's a reasonable tool for its signal:noise ratio.
-Chris


More information about the Intel-gfx mailing list