[Intel-gfx] [PATCH 1/2] drm/i915/psr2: Fix max resolution supported.

[Pandiyan, Dhinakaran]

On Tue, 2018-02-13 at 16:29 -0800, Rodrigo Vivi wrote:
> According to spec:
> "PSR2 is supported for pipe active sizes up to
> 3640 pixels wide and 2304 lines tall."
> 
> BSpec: 7713
> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index 7cd4b82c6a75..3d341a44e720 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -413,9 +413,9 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
>  		return;
>  	}
>  
> -	/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */
> -	if (adjusted_mode->crtc_hdisplay > 3200 ||
> -	    adjusted_mode->crtc_vdisplay > 2000) {
> +	/* PSR2 is restricted to work with panel resolutions up to 3640x2304 */
> +	if (adjusted_mode->crtc_hdisplay > 3640 ||
> +	    adjusted_mode->crtc_vdisplay > 2304) {
>  		DRM_DEBUG_KMS("PSR2 disabled, panel resolution too big\n");

How about changing this to 
DRM_DEBUG_KMS("PSR2 cannot be enabled, resolution > 3640x2304\n");


1) We aren't disabling PSR if it wasn't enabled in the first place.
2) Max resolution is platform specific, might be worth to debug log.

Either way,
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>


>  		return;
>  	}