[Intel-gfx] [PATCH v14 1/6] drm/i915: store all subslice masks

[Lionel Landwerlin]

On 22/02/18 17:53, Lionel Landwerlin wrote:
> +static inline u16 sseu_get_eus(const struct sseu_dev_info *sseu,
> +			       int slice, int subslice)
> +{
> +	int i, offset = sseu_eu_idx(sseu, slice, subslice);
> +	u16 eu_mask = 0;
> +
> +	for (i = 0;
> +	     i < DIV_ROUND_UP(sseu->max_eus_per_subslice, BITS_PER_BYTE); i++) {
> +		eu_mask = ((u16) sseu->eu_mask[offset + i]) <<
> +			(i * BITS_PER_BYTE);

Found a bug here (only affecting HSW with 10EUs per half-slice).
Should be eu_mask |= ...

> +	}
> +
> +	return eu_mask;
> +}
> +