[Intel-gfx] [PATCH 1/5] drm/i915: Improve PSR activation timing

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 28 00:26:01 UTC 2018


Quoting Andy Lutomirski (2018-02-24 00:07:23)
> On Tue, Feb 13, 2018 at 11:26 PM, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> > From: Andy Lutomirski <luto at kernel.org>
> >
> > +
> > +       dev_priv->psr.activate_timer.expires = jiffies - 1;
> 
> That can't possibly be okay.

As an initialisation value, set to the previous jiffie? You can set it
to the current jiffie, but then you have the issue of not noticing the
update to the current jiffie.

So how is this any more incorrect?
-Chris


More information about the Intel-gfx mailing list