[Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

Rhys Kidd rhyskidd at gmail.com
Wed Jan 10 05:22:23 UTC 2018


On 9 January 2018 at 05:11, Petri Latvala <petri.latvala at intel.com> wrote:

> Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
> commit.") added a use of poll() to igt_kms.c, but that file only
> includes poll.h when HAVE_UDEV is defined. Move the include outside
> the UDEV conditional.
>
> Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>

I have also hit this issue, and spun up locally the equivalent patch fix,
so also gets my:

Reviewed-by: Rhys Kidd <rhyskidd at gmail.com>


> ---
>  lib/igt_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index ec3b7167..069752ec 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -40,8 +40,8 @@
>  #endif
>  #ifdef HAVE_UDEV
>  #include <libudev.h>
> -#include <poll.h>
>  #endif
> +#include <poll.h>
>  #include <errno.h>
>  #include <time.h>
>
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20180110/a372f38c/attachment-0001.html>


More information about the Intel-gfx mailing list