[Intel-gfx] [PATCH i-g-t 1/2] test/gem_ctx_param - Use the last I915_CONTEXT_PARAM+1 for invalid tests

[Lofstedt, Marta]

> -----Original Message-----
> From: Tvrtko Ursulin [mailto:tvrtko.ursulin at linux.intel.com]
> Sent: Thursday, January 11, 2018 1:46 PM
> To: Lofstedt, Marta <marta.lofstedt at intel.com>; intel-
> gfx at lists.freedesktop.org
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Subject: Re: [Intel-gfx] [PATCH i-g-t 1/2] test/gem_ctx_param - Use the last
> I915_CONTEXT_PARAM+1 for invalid tests
> 
> 
> On 11/01/2018 11:38, Marta Lofstedt wrote:
> > The invalid-param-[get|set] exploits the last I915_CONTEXT_PARAM + 1,
> > to check for ABI extentsions. However, the last param was set to
> > I915_CONTEXT_PARAM_BANNABLE, so when
> I915_CONTEXT_PARAM_PRIORITY was
> > added to the next enum, the test started failing.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103107
> > Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> > ---
> >   tests/gem_ctx_param.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/gem_ctx_param.c b/tests/gem_ctx_param.c index
> > c20ae1ee..75d2a20f 100644
> > --- a/tests/gem_ctx_param.c
> > +++ b/tests/gem_ctx_param.c
> > @@ -140,7 +140,7 @@ igt_main
> >   	 * to catch ABI extensions. Don't "fix" this testcase without
> adding all
> >   	 * the tests for the new param first.
> >   	 */
> > -	arg.param = I915_CONTEXT_PARAM_BANNABLE + 1;
> > +	arg.param = I915_CONTEXT_PARAM_PRIORITY + 1;
> >
> >   	igt_subtest("invalid-param-get") {
> >   		arg.ctx_id = ctx;
> >
> 
> We tried before, last time AFAIR
> https://patchwork.freedesktop.org/patch/187073/, but again AFAIR I think
> Chris objected and would rather remove negative tests in general. Shrug, an
> impasse. :I
> 
Well, then maybe V2 will be to remove these test ;)

> Regards,
> 
> Tvrtko