[Intel-gfx] [PATCH] drm/i915: Simplify guard logic for setup_scratch_page()

Matthew Auld matthew.william.auld at gmail.com
Mon Jan 29 10:54:35 UTC 2018


On 29 January 2018 at 10:28, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Older gcc is complaining it can't follow the guards and thinks that
> addr may be used uninitialised
>
> In the process, we can simplify down to one loop,
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-131 (-131)
> Function                                     old     new   delta
> setup_scratch_page                           545     414    -131
>
> Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld at intel.com>

With or without __GFP_RETRY_MAYFAIL:

Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-gfx mailing list