[Intel-gfx] [PATCH] drm/i915: Simplify guard logic for setup_scratch_page()

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 29 20:53:21 UTC 2018


Quoting Matthew Auld (2018-01-29 10:54:35)
> On 29 January 2018 at 10:28, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Older gcc is complaining it can't follow the guards and thinks that
> > addr may be used uninitialised
> >
> > In the process, we can simplify down to one loop,
> > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-131 (-131)
> > Function                                     old     new   delta
> > setup_scratch_page                           545     414    -131
> >
> > Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.auld at intel.com>
> 
> With or without __GFP_RETRY_MAYFAIL:

Snuck it in.
 
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>

Ta, pushed. Remind me in 6 months (4.17) to see if we're finally clean.
-Chris


More information about the Intel-gfx mailing list