[Intel-gfx] [PATCH 03/11] drm/i915/execlists: Pull submit after dequeue under timeline lock

Chris Wilson chris at chris-wilson.co.uk
Fri Jun 1 14:07:57 UTC 2018


Quoting Tvrtko Ursulin (2018-06-01 15:02:38)
> 
> On 31/05/2018 19:51, Chris Wilson wrote:
> > In the next patch, we will begin processing the CSB from inside the
> > interrupt handler. This means that updating the execlists->port[] will
> 
> The message that we will be processing CSB from irq handler, here and in 
> following patch 5/11, doesn't seem to be true. So why is this needed? 
> Why not just drop some patches from the series?

It will still be called from irq context; as submit_request is called
from irq context. Hence we still require irqsafe variants.

So yes, while the overall direction of the patchset changed slightly to
be less enthusiastic about calling from irq context, such calls were not
eliminated.
-Chris


More information about the Intel-gfx mailing list