[Intel-gfx] [PATCH] drm/i915: Wedged engine mask makes more sense in hex

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 1 07:16:08 UTC 2018


Quoting Tvrtko Ursulin (2018-02-28 17:18:44)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> In decimal its just a weird big number, while in hex can actually log
> which engines were requested to be wedged.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Oh, and another thing that bugs me, is "action: reset". That's all we
say, and I think it's immaterial to the post-mortem error state. Just
creates extra work for me in removing that useless bit of information
when it gets cut and pasted into bug reports.
-Chris


More information about the Intel-gfx mailing list