[Intel-gfx] [PATCH 07/15] drm/i915/guc: Flush directly in log unregister
michal.winiarski at intel.com
Mon Mar 5 12:10:02 UTC 2018
On Mon, Mar 05, 2018 at 05:28:33PM +0530, Sagar Arun Kamble wrote:
> On 2/27/2018 6:22 PM, Michał Winiarski wrote:
> > Having both guc_flush_logs and guc_log_flush functions is confusing.
> > While we could just rename things, guc_flush_logs implementation is
> > quite simple. Let's get rid of it and move its content to unregister.
> > Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> this patch reminds me of need to do guc_log_flush in capture_uc_state prior
> to reset in case user wants to read
> updated log vma from error state. is this need valid?
I don't think so - force flush Host to GuC is related to "bookkeeping" (think
metadata describing log buffer state - HEAD/TAIL pointers etc).
In error state we don't care - we're dumping the whole log vma.
In case of relay - we're moving data around, and we need to know what data to
> > ---
> > drivers/gpu/drm/i915/intel_guc_log.c | 35 +++++++++++++++--------------------
> > 1 file changed, 15 insertions(+), 20 deletions(-)
More information about the Intel-gfx