[Intel-gfx] [igt-dev] [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

Daniel Vetter daniel at ffwll.ch
Tue Mar 6 14:42:59 UTC 2018


On Tue, Feb 20, 2018 at 12:22:19PM +0000, Chris Wilson wrote:
> Quoting Daniel Vetter (2018-02-20 12:17:18)
> > On Thu, Feb 15, 2018 at 09:21:47AM +0000, Chris Wilson wrote:
> > > Quoting Chris Wilson (2018-02-11 18:54:33)
> > > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > 
> > > Poke, CI is still tripping over this...
> > 
> > Can you give a bit more context about what's going on and how this
> > happens? Bugzilla or whatever ... I'm confused.
> 
> i915_fbc_status():
> 	if (!HAS_FBC(dev_priv))
> 		return -ENODEV;
> 
> So whenever CI is run on machines without FBC (all of its gen3-gen5
> machine, as the only ilk appears to be a desktop unless I missed one)
> buf is empty.

Oh, I entirely missed that we errno out the read right away in that case.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list