[Intel-gfx] [PATCH 3/4] drm/i915: Include i915_reg.h in intel_ringbuffer.h

[Tvrtko Ursulin]

On 06/03/2018 17:33, Chris Wilson wrote:
> Quoting Michal Wajdeczko (2018-03-06 16:15:26)
>> Header intel_ringbuffer.h is using definitions from i915_reg.h
>> but forget to include it. Remove this hidden dependency by
>> explicitly include missing header.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_ringbuffer.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
>> index e7526a4..cdea2ab 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
>> @@ -7,6 +7,7 @@
>>   #include "i915_gem_batch_pool.h"
>>   #include "i915_gem_timeline.h"
>>   
>> +#include "i915_reg.h"
> 
> Just the gpu commands, right? I'd like to pull those out of i915_reg.h!

The one I spotted by luck was VECS_HW. Maybe Michal has a more 
comprehensive list as output by the compiler when he found the problem.

Regards,

Tvrtko

> Could you add /* for MI_FLUSH_DW etc */ here as a hopeful reminder?
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>