[Intel-gfx] [PATCH v2 1/4] drm/i915: Include i915_reg.h in intel_ringbuffer.h

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Mar 7 12:49:47 UTC 2018


On 07/03/2018 12:47, Michal Wajdeczko wrote:
> Header intel_ringbuffer.h is using definitions from i915_reg.h
> but forget to include it. Remove this hidden dependency by
> explicitly include missing header.
> 
> v2: add reminder (Chris)
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com> #1

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

> ---
>   drivers/gpu/drm/i915/intel_ringbuffer.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index 26605f3..e4933dd 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -7,6 +7,7 @@
>   #include "i915_gem_batch_pool.h"
>   #include "i915_gem_timeline.h"
>   
> +#include "i915_reg.h" /* FIXME split out i915_gpu_commands.h */
>   #include "i915_pmu.h"
>   #include "i915_request.h"
>   #include "i915_selftest.h"
> 


More information about the Intel-gfx mailing list