[Intel-gfx] [PATCH v2 14/15] drm/i915/guc: Default to non-verbose GuC logging

[Sagar Arun Kamble]

On 3/8/2018 9:17 PM, Michał Winiarski wrote:
> Now that we've decoupled logging from relay, GuC log level is only
> controlling the GuC behavior - there shouldn't be any impact on i915
> behaviour. We're only going to see a single extra interrupt when log
> will get half full.
> That, and the fact that we're seeing igt/gem_exec_nop/basic-series
> failing with non-verbose logging being disabled.
>
> v2: Bring back the "auto" guc_log_level, now that we fixed the log
>
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com> (v1)
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> ---
>   drivers/gpu/drm/i915/i915_params.h | 2 +-
>   drivers/gpu/drm/i915/intel_uc.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 430f5f9d0ff4..c96360398072 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -48,7 +48,7 @@ struct drm_printer;
>   	param(int, enable_ips, 1) \
>   	param(int, invert_brightness, 0) \
>   	param(int, enable_guc, 0) \
> -	param(int, guc_log_level, 0) \
> +	param(int, guc_log_level, -1) \
>   	param(char *, guc_firmware_path, NULL) \
>   	param(char *, huc_firmware_path, NULL) \
>   	param(int, mmio_debug, 0) \
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index 3fb5f75aa7c9..2f579fff58cd 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -69,7 +69,7 @@ static int __get_platform_enable_guc(struct drm_i915_private *dev_priv)
>   
>   static int __get_default_guc_log_level(struct drm_i915_private *dev_priv)
>   {
> -	int guc_log_level = 0; /* disabled */
> +	int guc_log_level = 1; /* non-verbose */
>   
>   	/* Enable if we're running on platform with GuC and debug config */
>   	if (HAS_GUC(dev_priv) && intel_uc_is_using_guc() &&

-- 
Thanks,
Sagar