[Intel-gfx] [PATCH v13 00/17] Add NV12 support

Srinivas, Vidya vidya.srinivas at intel.com
Tue Mar 13 02:28:32 UTC 2018


Thank you so much. I will address the change suggested in patch 17.

Regards
Vidya

> -----Original Message-----
> From: Juha-Pekka Heikkila [mailto:juhapekka.heikkila at gmail.com]
> Sent: Monday, March 12, 2018 7:21 PM
> To: Srinivas, Vidya <vidya.srinivas at intel.com>; intel-
> gfx at lists.freedesktop.org
> Cc: Syrjala, Ville <ville.syrjala at intel.com>; Lankhorst, Maarten
> <maarten.lankhorst at intel.com>
> Subject: Re: [Intel-gfx] [PATCH v13 00/17] Add NV12 support
> 
> Just small nitpick at patch #17 but otherwise this set is
> 
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> 
> 
> On 09.03.2018 10:48, Vidya Srinivas wrote:
> > This patch series is adding NV12 support for Broxton display after
> > rebasing on latest drm-tip.
> > Initial series of the patches can be found here:
> > https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html
> >
> > Previous revision history:
> > The first version of patches were reviewed when floated by Chandra in
> > 2015 but currently there was a design change with respect to
> > - the way fb offset is handled
> > - the way rotation is handled
> > Current NV12 patch series has been ported as per the current changes
> > on drm-tip
> >
> > Review comments from Ville (12th June 2017) have been addressed
> Review
> > comments from Clinton A Taylor (7th July 2017) have been addressed
> >
> > Review comments from Clinton A Taylor (10th July 2017)
> > 	have been addressed. Had missed out tested-by/reviewed-by in the
> patches.
> > 	Fixed that error in this series.
> > 	Review comments from Ville (11th July 2017) addressed.
> > 	Review comments from Paauwe, Bob (29th July 2017) addressed.
> >
> > Update from rev 28 Aug 2017
> > 	Rebased the series.
> > 	Tested with IGT for rotation, sprite and tiling combinations.
> > 	IGT Links:
> > 	https://patchwork.kernel.org/patch/9995943/
> > 	https://patchwork.kernel.org/patch/9995945/
> > 	Review comments by Maarten are addressed in this series.
> > 	NV12 enabled for Gen10.
> > 	Review comments from Shashank Sharma are addressed.
> > 	IGT debug_fs test failure fixed.
> > 	Added reviewed-by tag from Shashank Sharma for few patches
> > 	Addressed comments from Juha-Pekka Heikkila in few patches
> > 	(NV12 not to be supported for SKL)
> > 	Adding an additional patch Display WA 827 for underrun during NV12
> > 	Adding more WA implementation to see if it helps underruns
> >
> > Update from previous series:
> > 	Rebased the series
> > 	Addressed review comments from Ville regarding the planar formats
> > 	Added minimum src height for yuv 420 planar formats
> > 	Added NV12 in skl_mod_supported
> >
> > Chandra Konduru (6):
> >    drm/i915: Set scaler mode for NV12
> >    drm/i915: Update format_is_yuv() to include NV12
> >    drm/i915: Upscale scaler max scale for NV12
> >    drm/i915: Add NV12 as supported format for primary plane
> >    drm/i915: Add NV12 as supported format for sprite plane
> >    drm/i915: Add NV12 support to intel_framebuffer_init
> >
> > Mahesh Kumar (9):
> >    drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values
> >    drm/i915/skl+: refactor WM calculation for NV12
> >    drm/i915/skl+: add NV12 in skl_format_to_fourcc
> >    drm/i915/skl+: support verification of DDB HW state for NV12
> >    drm/i915/skl+: NV12 related changes for WM
> >    drm/i915/skl+: pass skl_wm_level struct to wm compute func
> >    drm/i915/skl+: make sure higher latency level has higher wm value
> >    drm/i915/skl+: nv12 workaround disable WM level 1-7
> >    drm/i915/skl: split skl_compute_ddb function
> >
> > Vidya Srinivas (2):
> >    drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg
> >    drm/i915: Display WA 827
> >
> >   drivers/gpu/drm/i915/i915_drv.h      |  10 +-
> >   drivers/gpu/drm/i915/i915_reg.h      |   5 +
> >   drivers/gpu/drm/i915/intel_atomic.c  |  14 +-
> >   drivers/gpu/drm/i915/intel_display.c | 179 +++++++++++---
> >   drivers/gpu/drm/i915/intel_drv.h     |  12 +-
> >   drivers/gpu/drm/i915/intel_pm.c      | 438 ++++++++++++++++++++++----
> ---------
> >   drivers/gpu/drm/i915/intel_sprite.c  |  28 ++-
> >   7 files changed, 486 insertions(+), 200 deletions(-)
> >



More information about the Intel-gfx mailing list