[Intel-gfx] [DIM PATCH 3/3] dim: loosen some drm-intel checkpatch rules

Jani Nikula jani.nikula at intel.com
Tue Mar 13 11:30:10 UTC 2018

Set max line length to 100. I don't want to silence the LONG_LINE
warning altogether, and I'd still prefer to keep lines under 80
characters, but I also don't want to see all the noise, and nor do I
want to see silly code trying to arbitrarily squeeze under 80 when it
doesn't make sense. 100 is a nice arbitrary round number... I hope
review catches silly stuff regardless. Fingers crossed.

BIT_MACRO. We have (1 << N) all over the place. I hope to switch to
BIT() macro eventually, but this documents current use.

PREFER_KERNEL_TYPES. We also have uint(8|16|32|64)_t all over the
place. I also hope to move towards kernel types, but this documents
current use.

SPLIT_STRING, LONG_LINE_STRING. Don't nag about strings split to many
lines, but also don't nag about strings not split.

There's plenty more that could be tweaked, but let's start with
something to improve the S/N ratio of the automated CI checkpatch
reports. Now that we have --show-types included in the output, we can
more easily discuss the ignores on a case-by-case basis.

Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index 4ba1c7ff490a..9fa6d9cd855b 100755
--- a/dim
+++ b/dim
@@ -1390,7 +1390,7 @@ function checkpatch_commit
-			profile_options=""
+			profile_options="--max-line-length=100 --ignore=BIT_MACRO,PREFER_KERNEL_TYPES,SPLIT_STRING,LONG_LINE_STRING"
 			echoerr "Unknown checkpatch profile $profile"

More information about the Intel-gfx mailing list