[Intel-gfx] [PATCH] drm/i915: drop various VLAs in i915_debugfs.c

Jani Nikula jani.nikula at linux.intel.com
Wed Mar 14 12:17:07 UTC 2018

On Tue, 13 Mar 2018, Salvatore Mesoraca <s.mesoraca16 at gmail.com> wrote:
> Avoid 3 VLAs[1] by using real constant expressions instead of variables.
> The compiler should be able to optimize the original code and avoid using
> any actual VLAs. Anyway this change is useful because it will avoid a false
> positives with -Wvla, it might also help the compiler generating better
> code.

Thanks for your patch. However, Chris beat you to it with:

7aa0b14ede64 ("drm/i915: Remove variable length arrays from sseu debugfs

as well as adding -Wvla to our subdir-ccflags-y to prevent more from
cropping up:

c5c2b11894f4 ("drm/i915: Warn against variable length arrays")


Jani Nikula, Intel Open Source Technology Center

More information about the Intel-gfx mailing list