[Intel-gfx] [PATCH 25/36] drm/i915: Remove defunct intel_suspend_gt_powersave()

[Sagar Arun Kamble]

On 3/14/2018 3:07 PM, Chris Wilson wrote:
> Since commit b7137e0cf1e5 ("drm/i915: Defer enabling rc6 til after we
> submit the first batch/context"), intel_suspend_gt_powersave() has been
> a no-op. As we still do not need to do anything explicitly on suspend
> (we do everything required on idling), remove the defunct function.
>
> References: b7137e0cf1e5 ("drm/i915: Defer enabling rc6 til after we submit the first batch/context")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem.c    |  1 -
>   drivers/gpu/drm/i915/intel_gt_pm.c | 16 ----------------
>   drivers/gpu/drm/i915/intel_gt_pm.h |  1 -
>   3 files changed, 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index fbf8ccf57229..8112cbd6e0af 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4908,7 +4908,6 @@ int i915_gem_suspend(struct drm_i915_private *dev_priv)
>   	int ret;
>   
>   	intel_runtime_pm_get(dev_priv);
> -	intel_suspend_gt_powersave(dev_priv);
>   
>   	mutex_lock(&dev->struct_mutex);
>   
> diff --git a/drivers/gpu/drm/i915/intel_gt_pm.c b/drivers/gpu/drm/i915/intel_gt_pm.c
> index 21217a5c585a..42a048dca5bf 100644
> --- a/drivers/gpu/drm/i915/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/intel_gt_pm.c
> @@ -2475,22 +2475,6 @@ void intel_cleanup_gt_powersave(struct drm_i915_private *dev_priv)
>   		intel_runtime_pm_put(dev_priv);
>   }
>   
> -/**
> - * intel_suspend_gt_powersave - suspend PM work and helper threads
> - * @dev_priv: i915 device
> - *
> - * We don't want to disable RC6 or other features here, we just want
> - * to make sure any work we've queued has finished and won't bother
> - * us while we're suspended.
> - */
> -void intel_suspend_gt_powersave(struct drm_i915_private *dev_priv)
> -{
> -	if (INTEL_GEN(dev_priv) < 6)
> -		return;
> -
> -	/* gen6_rps_idle() will be called later to disable interrupts */
> -}
> -
>   void intel_sanitize_gt_powersave(struct drm_i915_private *dev_priv)
>   {
>   	dev_priv->gt_pm.rps.enabled = true; /* force RPS disabling */
> diff --git a/drivers/gpu/drm/i915/intel_gt_pm.h b/drivers/gpu/drm/i915/intel_gt_pm.h
> index 5ac16b614f8b..c0b3ab5e4046 100644
> --- a/drivers/gpu/drm/i915/intel_gt_pm.h
> +++ b/drivers/gpu/drm/i915/intel_gt_pm.h
> @@ -36,7 +36,6 @@ void intel_cleanup_gt_powersave(struct drm_i915_private *dev_priv);
>   void intel_sanitize_gt_powersave(struct drm_i915_private *dev_priv);
>   void intel_enable_gt_powersave(struct drm_i915_private *dev_priv);
>   void intel_disable_gt_powersave(struct drm_i915_private *dev_priv);
> -void intel_suspend_gt_powersave(struct drm_i915_private *dev_priv);
>   
>   void intel_gt_pm_irq_handler(struct drm_i915_private *dev_priv, u32 pm_iir);
>   

-- 
Thanks,
Sagar