[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Rework FBC schedule locking

[Jani Nikula]

On Fri, 16 Mar 2018, Patchwork <patchwork at emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: Rework FBC schedule locking
> URL   : https://patchwork.freedesktop.org/series/40102/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip

So I'll try to look at these reports a bit now that we've enabled them
with some filtering.

> 3bacd111d921 drm/i915: Rework FBC schedule locking
> -:93: WARNING:LONG_LINE: line over 100 characters
> #93: FILE: drivers/gpu/drm/i915/intel_fbc.c:425:
> +		!(vbl = atomic64_read(&work->scheduled_vblank)) || vbl != drm_crtc_vblank_count(&crtc->base),

I think this is a valid complaint. Please split the line after the ||.

BR,
Jani.

>
> total: 0 errors, 1 warnings, 0 checks, 173 lines checked
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center