[Intel-gfx] [PATCH 35/36] drm/i915: Remove unwarranted clamping for hsw/bdw

Sagar Arun Kamble sagar.a.kamble at intel.com
Mon Mar 19 07:32:04 UTC 2018



On 3/14/2018 3:07 PM, Chris Wilson wrote:
> We always start off at an "efficient frequency" and can let the system
> autotune from there, eliminating the need to clamp the available range.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_gt_pm.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_gt_pm.c b/drivers/gpu/drm/i915/intel_gt_pm.c
> index 6f5c14421c90..9705205a26b5 100644
> --- a/drivers/gpu/drm/i915/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/intel_gt_pm.c
> @@ -2432,17 +2432,9 @@ void intel_gt_pm_init(struct drm_i915_private *dev_priv)
>   		gen5_init_gt_powersave(dev_priv);
>   
>   	/* Derive initial user preferences/limits from the hardware limits */
> -	rps->idle_freq = rps->min_freq_hw;
> -
>   	rps->max_freq_user = rps->max_freq_hw;
>   	rps->min_freq_user = rps->min_freq_hw;
>   
> -	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> -		rps->min_freq_user =
> -			max_t(int,
> -			      rps->efficient_freq,
> -			      intel_freq_opcode(dev_priv, 450));
> -
>   	/* After setting max-softlimit, find the overclock max freq */
>   	if (IS_GEN6(dev_priv) ||
>   	    IS_IVYBRIDGE(dev_priv) || IS_HASWELL(dev_priv)) {
> @@ -2462,6 +2454,7 @@ void intel_gt_pm_init(struct drm_i915_private *dev_priv)
>   
>   	/* Finally allow us to boost to max by default */
>   	rps->boost_freq = rps->max_freq_hw;
> +	rps->idle_freq = rps->min_freq_hw;
>   
>   	rps->freq = rps->idle_freq;
>   	rps->min = rps->min_freq_hw;

-- 
Thanks,
Sagar



More information about the Intel-gfx mailing list