[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,01/13] drm/i915/guc: Keep GuC interrupts enabled when using GuC

[Patchwork]

== Series Details ==

Series: series starting with [v3,01/13] drm/i915/guc: Keep GuC interrupts enabled when using GuC
URL   : https://patchwork.freedesktop.org/series/40170/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
129696d8e7f5 drm/i915/guc: Keep GuC interrupts enabled when using GuC
b50a23b61dec drm/i915/guc: Log runtime should consist of both mapping and relay
-:337: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#337: FILE: drivers/gpu/drm/i915/intel_guc_log.h:52:
+		struct mutex lock;

total: 0 errors, 0 warnings, 1 checks, 287 lines checked
89ecad78c4f1 drm/i915/guc: Merge log relay file and channel creation
bee97b156e1e drm/i915/guc: Flush directly in log unregister
bad558e92b49 drm/i915/guc: Split relay control and GuC log level
6f79d3d70452 drm/i915/guc: Move check for fast memcpy_wc to relay creation
5b89313ecb62 drm/i915/guc: Get rid of GuC log runtime
-:46: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#46: FILE: drivers/gpu/drm/i915/intel_guc.c:91:
+	guc->log.relay.flush_wq = alloc_ordered_workqueue("i915-guc_log",
 						WQ_HIGHPRI | WQ_FREEZABLE);

-:120: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#120: FILE: drivers/gpu/drm/i915/intel_guc_log.c:248:
+	log_buf_state = src_data = log->relay.buf_addr;

-:154: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "log->relay.buf_addr"
#154: FILE: drivers/gpu/drm/i915/intel_guc_log.c:346:
+	return log->relay.buf_addr != NULL;

total: 0 errors, 0 warnings, 3 checks, 257 lines checked
db91e85e0a6a drm/i915/guc: Always print log stats in i915_guc_info when using GuC
-:49: WARNING:PREFER_SEQ_PUTS: Prefer seq_puts to seq_printf
#49: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2391:
+	seq_printf(m, "\nDoorbell map:\n");

total: 0 errors, 1 warnings, 0 checks, 38 lines checked
522e47939af7 drm/i915/guc: Don't print out relay statistics when relay is disabled
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
v3: Corrected one more error in stats accounting, move relay_enabled (Sagar)

-:172: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "log->relay.buf_addr"
#172: FILE: drivers/gpu/drm/i915/intel_guc_log.c:553:
+	return log->relay.buf_addr != NULL;

total: 0 errors, 1 warnings, 1 checks, 173 lines checked
3f8d2707e19e drm/i915/guc: Allow user to control default GuC logging
13e0fba2179c drm/i915/guc: Default to non-verbose GuC logging
dd4f4139736e drm/i915/guc: Demote GuC error messages
6d07a4068452 HAX enable guc for CI
-:19: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 8 lines checked