[Intel-gfx] [PATCH v3 2/3] drm/i915/guc: Drop union guc_log_control

Michał Winiarski michal.winiarski at intel.com
Mon Mar 19 17:18:14 UTC 2018


On Mon, Mar 19, 2018 at 04:20:02PM +0000, Michal Wajdeczko wrote:
> Usually we use shift/mask macros for bit field definitions.
> Union guc_log_control was not following that pattern.
> 
> Additional bonus:
> 
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-25 (-25)
> Function                                     old     new   delta
> intel_guc_log_level_set                      388     363     -25
> 
> v2: prevent out-of-range verbosity (MichalWi)
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>

Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

-Michał

> ---
>  drivers/gpu/drm/i915/intel_guc_fwif.h | 16 +++++-----------
>  drivers/gpu/drm/i915/intel_guc_log.c  | 13 +++++--------
>  2 files changed, 10 insertions(+), 19 deletions(-)


More information about the Intel-gfx mailing list