[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reword warning for missing cases (rev2)

Lucas De Marchi lucas.demarchi at intel.com
Mon Mar 19 21:55:11 UTC 2018


CCing checkpatch maintainers

On Mon, Mar 19, 2018 at 06:36:16PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Reword warning for missing cases (rev2)
> URL   : https://patchwork.freedesktop.org/series/39821/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> 7cb94d2c3c47 drm/i915: Reword warning for missing cases
> -:40: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
> #40: FILE: drivers/gpu/drm/i915/i915_utils.h:43:
> +#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> +			     __stringify(x), (long)(x))

checkpatch seems wrong here since __stringify() doesn't evaluate x. And
it looks similar to the one fixed by
e942e2c3f7e0 ("checkpatch: fix stringification macro defect")


Lucas De Marchi


> 
> total: 0 errors, 0 warnings, 1 checks, 10 lines checked
> 


More information about the Intel-gfx mailing list