[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 19 22:34:12 UTC 2018


== Series Details ==

Series: series starting with [1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads
URL   : https://patchwork.freedesktop.org/series/40233/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e6a22b973125 drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads
-:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around sseu->slice_mask
#39: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:802:
+	u32 slice = find_last_bit((unsigned long *)&(sseu->slice_mask),

-:41: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around sseu->subslice_mask[slice]
#41: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:804:
+	u32 subslice = find_last_bit((unsigned long *)&(sseu->subslice_mask[slice]),

total: 0 errors, 0 warnings, 2 checks, 71 lines checked
254d3c903a5e drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads
-:55: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around sseu->slice_mask
#55: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:827:
+		slice = find_last_bit((unsigned long *)&(sseu->slice_mask),

-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:828:
+		slice = find_last_bit((unsigned long *)&(sseu->slice_mask),
+				       sizeof(sseu->slice_mask));

-:60: CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#60: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:832:
+			       | sseu->subslice_mask[slice]>>GEN10_L3BANK_PAIR_COUNT)
 			                                   ^

total: 0 errors, 0 warnings, 3 checks, 36 lines checked



More information about the Intel-gfx mailing list