[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Add control flags to i915_handle_error()

Patchwork patchwork at emeril.freedesktop.org
Tue Mar 20 01:24:30 UTC 2018


== Series Details ==

Series: series starting with [1/5] drm/i915: Add control flags to i915_handle_error()
URL   : https://patchwork.freedesktop.org/series/40240/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b279af513a73 drm/i915: Add control flags to i915_handle_error()
-:111: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#111: FILE: drivers/gpu/drm/i915/i915_drv.h:2703:
+extern void i915_reset(struct drm_i915_private *i915, const char *msg);

-:112: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#112: FILE: drivers/gpu/drm/i915/i915_drv.h:2704:
+extern int i915_reset_engine(struct intel_engine_cs *engine, const char *msg);

total: 0 errors, 0 warnings, 2 checks, 273 lines checked
76088d3cc0fb drm/i915/execlists: Refactor out complete_preempt_context()
fe83f1c114bf drm/i915: Move engine reset prepare/finish to backends
597e8d4ae7a5 drm/i915: Split execlists/guc reset prepartions
2950e96e849d drm/i915/execlists: Flush pending preemption events during reset
-:103: WARNING:LONG_LINE: line over 100 characters
#103: FILE: drivers/gpu/drm/i915/intel_lrc.c:879:
+		  head, GEN8_CSB_READ_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?",

-:104: WARNING:LONG_LINE: line over 100 characters
#104: FILE: drivers/gpu/drm/i915/intel_lrc.c:880:
+		  tail, GEN8_CSB_WRITE_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?");

-:159: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#159: FILE: drivers/gpu/drm/i915/intel_lrc.c:911:
+			  status, buf[2*head + 1],
 			               ^

-:188: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#188: FILE: drivers/gpu/drm/i915/intel_lrc.c:929:
+		    buf[2*head + 1] == execlists->preempt_complete_status) {
 		         ^

total: 0 errors, 2 warnings, 2 checks, 396 lines checked



More information about the Intel-gfx mailing list