[Intel-gfx] [PATCH] drm/i915/pm: Warn if rpm frequencies are not set

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Mar 20 14:39:59 UTC 2018

Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2018-03-20 13:58:42)
>> We do end up setting ring frequencies on a hardware
>> which is not yet there wrt runtime pm enablement.
>> Instead of ending up in an endless loop iterating through
>> frequencies if min and max frequencies are still set to zero,
>> warn and bail out early.
> Hmm, if you are hitting this in practice, I
> would just go with

I did.

> if (rps->max_freq <= rps->min_freq)
> 	return;

Ok, this is enough to fix the loop..

> I'm sure we have warnings else where for invalid min/max freq.

but I didn't bump into any of these.

> Don't worry about min_ring_freq unless you have a document that says
> otherwise.

Yeah, different story for that one.

More information about the Intel-gfx mailing list