[Intel-gfx] [PATCH 2/2] drm/i915: Warn if rps max frequency is not set

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 20 18:01:30 UTC 2018


Quoting Mika Kuoppala (2018-03-20 16:28:20)
> Mika Kuoppala <mika.kuoppala at linux.intel.com> writes:
> 
> > Warn on enabling rps when our hw max is invalid.
> >
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 19e82aaa9863..bc335c52a17a 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -8157,6 +8157,8 @@ static void intel_enable_rps(struct drm_i915_private *dev_priv)
> >               intel_init_emon(dev_priv);
> >       }
> >  
> > +     WARN_ON(rps->max_freq == 0);
> > +
> Ok, this wont fly with gen < 6

Close, we can just guard these by HAS_RPS. I think there's a series you
might want to review...
-Chris


More information about the Intel-gfx mailing list