[Intel-gfx] [PATCH v2 1/2] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Mar 22 09:25:40 UTC 2018


On 21/03/2018 14:29, Jani Nikula wrote:
> Prefer INTEL_GEN() over INTEL_INFO()->gen except in special
> circumstances.
> 
> v2: don't change device info dump (Chris)
> 
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index a504281e2afa..477cb71b5864 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -809,7 +809,7 @@ void intel_device_info_runtime_init(struct intel_device_info *info)
>   		gen9_sseu_info_init(dev_priv);
>   	else if (INTEL_GEN(dev_priv) == 10)
>   		gen10_sseu_info_init(dev_priv);
> -	else if (INTEL_INFO(dev_priv)->gen >= 11)
> +	else if (INTEL_GEN(dev_priv) >= 11)
>   		gen11_sseu_info_init(dev_priv);
>   
>   	/* Initialize command stream timestamp frequency */
> 

I was waiting for directly involved parties to feel moral responsibility 
to send this followup. ;)

Regards,

Tvrtko


More information about the Intel-gfx mailing list