[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Eliminate plane->fb/crtc usage for atomic drivers

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 22 16:38:19 UTC 2018


== Series Details ==

Series: drm: Eliminate plane->fb/crtc usage for atomic drivers
URL   : https://patchwork.freedesktop.org/series/40478/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8af098617121 Revert "drm/atomic-helper: Fix leak in disable_all"
03876a233cc7 drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers
-:93: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#93: FILE: drivers/gpu/drm/drm_atomic_helper.c:2952:
 }
+/**

total: 0 errors, 0 warnings, 1 checks, 98 lines checked
224a3f4b99a5 drm: Clear crtc->primary->crtc when disabling the crtc via setcrtc()
c3954d83df2f drm/atomic-helper: WARN if legacy plane fb pointers are bogus when committing duplicated state
6580440ce62b drm: Add local 'plane' variable for primary/cursor planes
-:121: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#121: FILE: drivers/gpu/drm/drm_plane.c:773:
+	BUG_ON(!plane);

-:122: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane->crtc"
#122: FILE: drivers/gpu/drm/drm_plane.c:774:
+	WARN_ON(plane->crtc != crtc && plane->crtc != NULL);

-:171: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!plane->fb"
#171: FILE: drivers/gpu/drm/drm_plane.c:1014:
+	if (plane->fb == NULL) {

total: 0 errors, 1 warnings, 2 checks, 186 lines checked
c5f62380d076 drm: Adjust whitespace for legibility
a7e79ff637c5 drm: Make the fb refcount handover less magic
b3b47d829071 drm: Use plane->state->fb over plane->fb
-:90: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!old_fb"
#90: FILE: drivers/gpu/drm/drm_plane.c:1024:
+	if (old_fb == NULL) {

total: 0 errors, 0 warnings, 1 checks, 79 lines checked
8ea5e6add2d4 drm/i915: Stop consulting plane->fb
ae87bf410783 drm/msm: Stop consulting plane->fb
7c4e668f28fa drm/sti: Stop consulting plane->fb
610d46292088 drm/vmwgfx: Stop consulting plane->fb
9be6d164afc9 drm/zte: Stop consulting plane->fb
bfa847ae0a04 drm/atmel-hlcdc: Stop using plane->fb
44c1635bfc7d drm: Stop updating plane->crtc/fb/old_fb on atomic drivers
54454e18424d drm/amdgpu/dc: Stop updating plane->fb
b2817ab02542 drm/i915: Stop updating plane->fb/crtc
12ec4c91178b drm/exynos: Stop updating plane->crtc
d79a0cea6333 drm/msm: Stop updating plane->fb/crtc
39c3be848eb9 drm/virtio: Stop updating plane->fb
6994f330dc05 drm/vc4: Stop updating plane->fb/crtc
ea19ce070e91 drm/i915: Restore planes after load detection
9ed8bc3b37c4 drm/i915: Make force_load_detect effective even w/ DMI quirks/hotplug



More information about the Intel-gfx mailing list