[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Eliminate plane->fb/crtc usage for atomic drivers (rev4)

[Patchwork]

== Series Details ==

Series: drm: Eliminate plane->fb/crtc usage for atomic drivers (rev4)
URL   : https://patchwork.freedesktop.org/series/40478/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c15222c5376f Revert "drm/atomic-helper: Fix leak in disable_all"
e1c1c0c2616b drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers
-:93: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#93: FILE: drivers/gpu/drm/drm_atomic_helper.c:2952:
 }
+/**

total: 0 errors, 0 warnings, 1 checks, 98 lines checked
83ae766ecf59 drm: Clear crtc->primary->crtc when disabling the crtc via setcrtc()
7a9501d57103 drm/atomic-helper: WARN if legacy plane fb pointers are bogus when committing duplicated state
591ea3185c8b drm: Add local 'plane' variable for primary/cursor planes
-:121: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#121: FILE: drivers/gpu/drm/drm_plane.c:773:
+	BUG_ON(!plane);

-:122: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane->crtc"
#122: FILE: drivers/gpu/drm/drm_plane.c:774:
+	WARN_ON(plane->crtc != crtc && plane->crtc != NULL);

-:171: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!plane->fb"
#171: FILE: drivers/gpu/drm/drm_plane.c:1014:
+	if (plane->fb == NULL) {

total: 0 errors, 1 warnings, 2 checks, 186 lines checked
1c416abc1569 drm: Adjust whitespace for legibility
5725ad36f927 drm: Make the fb refcount handover less magic
0c86fdf2fc0a drm: Use plane->state->fb over plane->fb
-:90: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!old_fb"
#90: FILE: drivers/gpu/drm/drm_plane.c:1024:
+	if (old_fb == NULL) {

total: 0 errors, 0 warnings, 1 checks, 79 lines checked
973ef243f6f2 drm/i915: Stop consulting plane->fb
8725c9242cc1 drm/msm: Stop consulting plane->fb
935907ed7ad6 drm/sti: Stop consulting plane->fb
9f0e4d0b9e42 drm/vmwgfx: Stop consulting plane->fb
a3badb58385a drm/zte: Stop consulting plane->fb
588e4c26248d drm/atmel-hlcdc: Stop using plane->fb
1163ef51d4d6 drm: Stop updating plane->crtc/fb/old_fb on atomic drivers
8f452e9c6e6d drm/amdgpu/dc: Stop updating plane->fb
337b7212bf2c drm/i915: Stop updating plane->fb/crtc
e20bc30e5a6b drm/exynos: Stop updating plane->crtc
38ee91954b33 drm/msm: Stop updating plane->fb/crtc
8c80fa662591 drm/virtio: Stop updating plane->crtc
32af98aba537 drm/vc4: Stop updating plane->fb/crtc
b4e5a00d654e drm/i915: Restore planes after load detection
ad0944dbaf79 drm/i915: Make force_load_detect effective even w/ DMI quirks/hotplug