[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Support for Guc responses and requests (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/guc: Support for Guc responses and requests (rev2)
URL   : https://patchwork.freedesktop.org/series/28393/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a60fcd18ab16 drm/i915/guc: Add documentation for MMIO based communication
-:166: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects?
#166: FILE: drivers/gpu/drm/i915/intel_guc_fwif.h:666:
+#define INTEL_GUC_MSG_IS_RESPONSE_SUCCESS(m) \
+	((INTEL_GUC_MSG_TO_TYPE(m) == INTEL_GUC_MSG_TYPE_RESPONSE) && \
+	 (INTEL_GUC_MSG_TO_CODE(m) == INTEL_GUC_RESPONSE_STATUS_SUCCESS))

total: 0 errors, 0 warnings, 1 checks, 142 lines checked
a38b1b1e3992 drm/i915/guc: Add support for data reporting in GuC responses
ba4f9e887323 drm/i915/guc: Prepare send() function to accept bigger response
ab9a3a86d8af drm/i915/guc: Implement response handling in send_mmio()
c2ad84a29d7c drm/i915/guc: Make event handler a virtual function
7a71bdc5c387 drm/i915/guc: Prepare to handle messages from CT RECV buffer
-:106: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#106: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:506:
+		DRM_ERROR("CT: corrupted response %*phn\n", 4*len, msg);
 		                                             ^

-:111: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#111: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:511:
+		DRM_ERROR("CT: corrupted response %*phn\n", 4*len, msg);
 		                                             ^

-:133: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#133: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:533:
+	u32 msg[GUC_CT_MSG_LEN_MASK+1]; /* one extra dw for the header */
 	                           ^

total: 0 errors, 0 warnings, 3 checks, 156 lines checked
1bce5e250d4f drm/i915/guc: Use better name for helper wait function
3c6c074c2832 drm/i915/guc: Implement response handling in send_ct()
-:227: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#227: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:618:
+				  req->fence, 4*len, msg);
 				               ^

-:231: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#231: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:622:
+			memcpy(req->response_buf, msg + 3, 4*payload_len);
 			                                    ^

-:241: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#241: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:631:
+		DRM_ERROR("CT: unsolicited response %*phn\n", 4*len, msg);
 		                                               ^

-:260: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#260: FILE: drivers/gpu/drm/i915/intel_guc_ct.h:81:
+	spinlock_t lock;

total: 0 errors, 0 warnings, 4 checks, 228 lines checked
a6ef9e1ee9b7 drm/i915/guc: Prepare to process incoming requests from CT
-:60: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#60: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:650:
+			  action, 4*len, payload);
 			           ^

-:111: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#111: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:700:
+	request = kmalloc(sizeof(*request) + 4*len, GFP_ATOMIC);
 	                                      ^

-:113: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#113: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:702:
+		DRM_ERROR("CT: dropping request %*phn\n", 4*len, msg);
 		                                           ^

-:116: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#116: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:705:
+	memcpy(request->data, msg, 4*len);
 	                            ^

total: 0 errors, 0 warnings, 4 checks, 116 lines checked
ddde59b7d24c drm/i915/guc: Enable GuC interrupts when using CT
acf08ee20d5a drm/i915/guc: Handle default action received over CT
aca333d32f3e drm/i915/guc: Trace messages from CT while in debug
-:118: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#118: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:347:
+			4*(len - 1), &action[1]);
 			 ^

-:150: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#150: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:605:
+	CT_DEBUG_DRIVER("CT: received %*phn\n", 4*len, data);
 	                                         ^

-:175: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#175: FILE: drivers/gpu/drm/i915/intel_guc_ct.c:668:
+	CT_DEBUG_DRIVER("CT: request %x %*phn\n", action, 4*len, payload);
 	                                                   ^

total: 0 errors, 0 warnings, 3 checks, 142 lines checked
6f34cddf2ca7 HAX: Enable GuC for CI