[Intel-gfx] [PATCH v4 10/13] drm/i915/guc: Enable GuC interrupts when using CT

Michel Thierry michel.thierry at intel.com
Fri Mar 23 23:02:15 UTC 2018


On 3/23/2018 7:47 AM, Michal Wajdeczko wrote:
> We will need them in G2H communication to properly handle
> responses and requests from the Guc.
> 
> v2: keep irq enabled while disabling GuC logging (Oscar)
> v3: rebase.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Oscar Mateo <oscar.mateo at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michel Thierry <michel.thierry at intel.com>
> Acked-by: Oscar Mateo <oscar.mateo at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index 8dc6a9c..9c20b1b 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -481,7 +481,7 @@ int intel_uc_resume(struct drm_i915_private *i915)
>   	if (guc->fw.load_status != INTEL_UC_FIRMWARE_SUCCESS)
>   		return 0;
>   
> -	if (i915_modparams.guc_log_level)
> +	if (HAS_GUC_CT(i915) || i915_modparams.guc_log_level)
>   		gen9_enable_guc_interrupts(i915);
>   
>   	err = intel_guc_resume(guc);
> 

This is no longer needed when this patch gets merged 
https://patchwork.freedesktop.org/patch/211397/


More information about the Intel-gfx mailing list