[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Eliminate plane->fb/crtc usage for atomic drivers (rev5)

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 26 12:28:27 UTC 2018


== Series Details ==

Series: drm: Eliminate plane->fb/crtc usage for atomic drivers (rev5)
URL   : https://patchwork.freedesktop.org/series/40478/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
eec2e4920fa9 Revert "drm/atomic-helper: Fix leak in disable_all"
885b9185b11c drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers
-:93: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#93: FILE: drivers/gpu/drm/drm_atomic_helper.c:2952:
 }
+/**

total: 0 errors, 0 warnings, 1 checks, 98 lines checked
565952128dd5 drm: Clear crtc->primary->crtc when disabling the crtc via setcrtc()
9847962e92bf drm/atomic-helper: WARN if legacy plane fb pointers are bogus when committing duplicated state
c82dc4275c43 drm: Add local 'plane' variable for primary/cursor planes
-:121: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#121: FILE: drivers/gpu/drm/drm_plane.c:773:
+	BUG_ON(!plane);

-:122: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane->crtc"
#122: FILE: drivers/gpu/drm/drm_plane.c:774:
+	WARN_ON(plane->crtc != crtc && plane->crtc != NULL);

-:171: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!plane->fb"
#171: FILE: drivers/gpu/drm/drm_plane.c:1014:
+	if (plane->fb == NULL) {

total: 0 errors, 1 warnings, 2 checks, 186 lines checked
755974d48345 drm: Adjust whitespace for legibility
f3e2f2d38a43 drm: Make the fb refcount handover less magic
9fd23bc1fc50 drm: Use plane->state->fb over plane->fb
-:90: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!old_fb"
#90: FILE: drivers/gpu/drm/drm_plane.c:1024:
+	if (old_fb == NULL) {

total: 0 errors, 0 warnings, 1 checks, 79 lines checked
7fe441e1f443 drm/i915: Stop consulting plane->fb
c63ecc6320ad drm/msm: Stop consulting plane->fb
9aee2233a34a drm/sti: Stop consulting plane->fb
260aa997ef90 drm/vmwgfx: Stop consulting plane->fb
213b45d96872 drm/zte: Stop consulting plane->crtc
ab4d18f860a9 drm/atmel-hlcdc: Stop using plane->fb
9295b76b993d drm: Stop updating plane->crtc/fb/old_fb on atomic drivers
98c28044ce49 drm/amdgpu/dc: Stop updating plane->fb
9eb46f68d697 drm/i915: Stop updating plane->fb/crtc
dd5198a96fab drm/exynos: Stop updating plane->crtc
5c81f06359a0 drm/msm: Stop updating plane->fb/crtc
7ea33fb4ffda drm/virtio: Stop updating plane->crtc
af0596d92fc4 drm/vc4: Stop updating plane->fb/crtc
d8e5f287c232 drm/i915: Restore planes after load detection
5b47761e238f drm/i915: Make force_load_detect effective even w/ DMI quirks/hotplug



More information about the Intel-gfx mailing list