[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: enable perf support on ICL (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 26 13:59:01 UTC 2018


== Series Details ==

Series: drm/i915/perf: enable perf support on ICL (rev2)
URL   : https://patchwork.freedesktop.org/series/39689/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
778ddd601367 drm/i915/icl: read timestamp frequency information
-:19: WARNING:LONG_LINE: line over 100 characters
#19: FILE: drivers/gpu/drm/i915/i915_reg.h:865:
+#define  GEN11_RPM_CONFIG0_CRYSTAL_CLOCK_FREQ_MASK	(7 << GEN11_RPM_CONFIG0_CRYSTAL_CLOCK_FREQ_SHIFT)

total: 0 errors, 1 warnings, 0 checks, 78 lines checked
2996b3ba1d5d drm/i915/perf: enable perf support on ICL
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

-:146: WARNING:LONG_LINE: line over 100 characters
#146: FILE: drivers/gpu/drm/i915/i915_oa_icl.c:113:
+	dev_priv->perf.oa.test_config.attrs[0] = &dev_priv->perf.oa.test_config.sysfs_metric_id.attr;

-:189: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#189: FILE: drivers/gpu/drm/i915/i915_oa_icl.h:32:
+extern void i915_perf_load_test_config_icl(struct drm_i915_private *dev_priv);

total: 0 errors, 2 warnings, 1 checks, 192 lines checked
9813c9041d52 drm/i915/perf: use IS_GEN() instead an or condition



More information about the Intel-gfx mailing list