[Intel-gfx] [PATCH v2] drm/i915: Reword warning for missing cases
rodrigo.vivi at intel.com
Tue Mar 27 17:37:49 UTC 2018
On Mon, Mar 19, 2018 at 09:41:32PM +0000, Chris Wilson wrote:
> Quoting Lucas De Marchi (2018-03-19 17:37:20)
> > In some places we end up converting switch statements to a series of
> > if/else, particularly when introducing helper functions to handle a
> > group of cases. It's tempting to either leave a wrong warning (since now
> > we don't have a switch case anymore) or to convert to WARN(1, ...),
> > but we can just provide a better message and avoid the doubt when such
> > conversions arrise.
> > Introducing a warning inside i915_driver_load() just for tests we get:
> > [ 4535.233717] Missing case (ret == 0)
> > [ 4535.233868] WARNING: CPU: 1 PID: 795 at drivers/gpu/drm/i915/i915_drv.c:1341 i915_driver_load+0x42/0x10e0 [i915]
> > which is clear enough.
> > v2: remove __func__ since this is already on the warning.
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
pushed to dinq. thanks for patch and reviews.
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
More information about the Intel-gfx