[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915/execlists: Refactor out complete_preempt_context()

Patchwork patchwork at emeril.freedesktop.org
Wed Mar 28 22:43:39 UTC 2018


== Series Details ==

Series: series starting with [01/15] drm/i915/execlists: Refactor out complete_preempt_context()
URL   : https://patchwork.freedesktop.org/series/40834/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a016c0c4e8a6 drm/i915/execlists: Refactor out complete_preempt_context()
6b5073664b45 drm/i915: Move engine reset prepare/finish to backends
80be3f4d08e2 drm/i915: Split execlists/guc reset prepartions
db3735949903 drm/i915/execlists: Flush pending preemption events during reset
-:69: WARNING:LONG_LINE: line over 100 characters
#69: FILE: drivers/gpu/drm/i915/intel_lrc.c:892:
+				(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_BUF_LO(engine, 0)));

-:87: WARNING:LONG_LINE: line over 100 characters
#87: FILE: drivers/gpu/drm/i915/intel_lrc.c:906:
+			head = readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)));

-:104: WARNING:LONG_LINE: line over 100 characters
#104: FILE: drivers/gpu/drm/i915/intel_lrc.c:920:
+			  head, GEN8_CSB_READ_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?",

-:105: WARNING:LONG_LINE: line over 100 characters
#105: FILE: drivers/gpu/drm/i915/intel_lrc.c:921:
+			  tail, GEN8_CSB_WRITE_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?");

total: 0 errors, 4 warnings, 0 checks, 192 lines checked
c2d26a6b71cd drm/i915/selftests: Add basic sanitychecks for execlists
-:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

-:119: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#119: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:72:
+	return hws->node.start + offset_in_page(sizeof(u32)*rq->fence.context);
 	                                                   ^

-:247: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects?
#247: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:200:
+#define wedge_on_timeout(W, DEV, TIMEOUT)				\
+	for (__init_wedge((W), (DEV), (TIMEOUT), __builtin_return_address(0)); \
+	     (W)->i915;							\
+	     __fini_wedge((W)))

total: 0 errors, 1 warnings, 2 checks, 505 lines checked
1a8b968124e3 drm/i915: Only warn for might_sleep() before a slow wait_for_register
82444332ae36 drm/i915/breadcrumbs: Keep the fake irq armed across reset
b2e8409ea500 drm/i915: Combine tasklet_kill and tasklet_disable
-:39: WARNING:MEMORY_BARRIER: memory barrier without comment
#39: FILE: drivers/gpu/drm/i915/intel_lrc.c:1732:
+	smp_mb();

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
2f07ace7b0a7 drm/i915: Stop parking the signaler around reset
-:13: WARNING:TYPO_SPELLING: 'choosen' may be misspelled - perhaps 'chosen'?
#13: 
advancing so that the GPU doesn't emit the breadcrumb for our choosen

total: 0 errors, 1 warnings, 0 checks, 117 lines checked
c4b8e41b9b87 drm/i915: Avoid sleeping inside per-engine reset
11775354141a drm/i915/execlists: Force preemption via reset on timeout
-:211: ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#211: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:502:
+	ctx= kernel_context(i915);
 	   ^

total: 1 errors, 0 warnings, 0 checks, 229 lines checked
300a185c5f0b drm/i915/execlists: Try preempt-reset from softirq context
-:95: ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#95: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:566:
+	ctx= kernel_context(i915);
 	   ^

total: 1 errors, 0 warnings, 0 checks, 136 lines checked
d380772d786f drm/i915/preemption: Select timeout when scheduling
cb74c3cdc9be drm/i915: Use a preemption timeout to enforce interactivity
b119d45a2d96 drm/i915: Allow user control over preempt timeout on the important context



More information about the Intel-gfx mailing list