[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4)

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 29 14:08:13 UTC 2018


== Series Details ==

Series: YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4)
URL   : https://patchwork.freedesktop.org/series/36068/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2b5dfa9c4aa1 drm/i915: Introduce CRTC output format
-:86: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#86: FILE: drivers/gpu/drm/i915/intel_display.c:10688:
+	DRM_DEBUG_KMS("output format: %s\n",
+		output_formats(pipe_config->output_format));

total: 0 errors, 0 warnings, 1 checks, 139 lines checked
ce026cbd59bf drm/i915: Add CRTC output format YCBCR 4:2:0
-:88: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#88: FILE: drivers/gpu/drm/i915/intel_display.c:7659:
+static void intel_get_crtc_ycbcr_config(struct intel_crtc *crtc,
+				    struct intel_crtc_state *pipe_config)

-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#191: FILE: drivers/gpu/drm/i915/intel_display.c:10681:
+	if (format < INTEL_OUTPUT_FORMAT_RGB ||
+		format > ARRAY_SIZE(output_format_str))

total: 0 errors, 0 warnings, 2 checks, 204 lines checked
589f5c1ab004 drm/i915: Add CRTC output format YCBCR 4:4:4
-:37: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#37: FILE: drivers/gpu/drm/i915/intel_color.c:153:
+	if (intel_crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
+	intel_crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR444) {

total: 0 errors, 0 warnings, 1 checks, 58 lines checked
f314d0a6f3c4 drm/i915: Check LSPCON vendor OUI
0851a6cc6bb1 drm/i915: Add AVI infoframe support for LSPCON
e0c80446404d drm/i915: Write AVI infoframes for MCA LSPCON
-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/intel_drv.h:2159:
+void lspcon_write_infoframe(struct drm_encoder *encoder,
+			     const struct intel_crtc_state *crtc_state,

-:79: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#79: FILE: drivers/gpu/drm/i915/intel_lspcon.c:244:
+static bool _lspcon_write_avi_infoframe_mca(struct drm_dp_aux *aux,
+					     const uint8_t *buffer, ssize_t len)

-:128: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#128: FILE: drivers/gpu/drm/i915/intel_lspcon.c:293:
+void lspcon_write_infoframe(struct drm_encoder *encoder,
+			     const struct intel_crtc_state *crtc_state,

-:151: CHECK:LINE_SPACING: Please don't use multiple blank lines
#151: FILE: drivers/gpu/drm/i915/intel_lspcon.c:316:
+
+

total: 0 errors, 0 warnings, 4 checks, 110 lines checked
49398d81198f drm/i915: Write AVI infoframes for Parade LSPCON
-:56: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#56: FILE: drivers/gpu/drm/i915/intel_lspcon.c:257:
+	for (retry = 0; retry < 5; retry++) {
+

-:76: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#76: FILE: drivers/gpu/drm/i915/intel_lspcon.c:277:
+static bool _lspcon_parade_write_infoframe_blocks(struct drm_dp_aux *aux,
+					       uint8_t *avi_buf)

-:85: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#85: FILE: drivers/gpu/drm/i915/intel_lspcon.c:286:
+	while (block_count < 4) {
+

-:88: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#88: FILE: drivers/gpu/drm/i915/intel_lspcon.c:289:
+			DRM_DEBUG_KMS("LSPCON FW not ready, block %d\n",
+				       block_count);

-:97: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#97: FILE: drivers/gpu/drm/i915/intel_lspcon.c:298:
+			DRM_ERROR("Failed to write AVI IF block %d\n",
+				   block_count);

-:112: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#112: FILE: drivers/gpu/drm/i915/intel_lspcon.c:313:
+			DRM_ERROR("Failed to update (0x%x), block %d\n",
+					reg, block_count);

total: 0 errors, 0 warnings, 6 checks, 143 lines checked
dc7f98442172 drm/i915: Add YCBCR 4:2:0/4:4:4 support for LSPCON
-:53: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#53: FILE: drivers/gpu/drm/i915/i915_reg.h:8721:
+#define  TRANS_MSA_SAMPLING_444        (2<<1)
                                          ^

-:54: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#54: FILE: drivers/gpu/drm/i915/i915_reg.h:8722:
+#define  TRANS_MSA_CLRSP_YCBCR		(2<<3)
                               		  ^

total: 0 errors, 0 warnings, 2 checks, 128 lines checked



More information about the Intel-gfx mailing list