[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm: Add drm/kernel.h header file

Patchwork patchwork at emeril.freedesktop.org
Mon Sep 3 17:47:07 UTC 2018


== Series Details ==

Series: series starting with [01/14] drm: Add drm/kernel.h header file
URL   : https://patchwork.freedesktop.org/series/49089/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a39d30c28e70 drm: Add drm/kernel.h header file
-:139: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#139: 
new file mode 100644

-:144: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#144: FILE: include/drm/kernel.h:1:
+/*

-:173: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#173: FILE: include/drm/kernel.h:30:
+#define for_each_if(condition) if (!(condition)) {} else

-:173: WARNING:BRACES: braces {} are not necessary for single statement blocks
#173: FILE: include/drm/kernel.h:30:
+#define for_each_if(condition) if (!(condition)) {} else

total: 1 errors, 3 warnings, 0 checks, 105 lines checked
4e507bab6b77 drm: Drop drmP.h from drm_connector.c
-:56: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 30 lines checked
963a78e5752b drm: drop drmP.h include from drm_plane.c
-:92: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 55 lines checked
acd20948fa62 drm: drop drmP.h include from drm_crtc.c
-:35: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 17 lines checked
d53335198614 drm/atomic: trim driver interface/docs
-:88: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#88: FILE: drivers/gpu/drm/drm_atomic.c:501:
+static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,
 		struct drm_crtc_state *state, struct drm_property *property,

-:202: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#202: FILE: drivers/gpu/drm/drm_atomic.c:1253:
+static int drm_atomic_set_writeback_fb_for_connector(

-:342: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 2 checks, 301 lines checked
2433899462b1 drm: extract drm_atomic_uapi.c
-:1498: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1498: 
new file mode 100644

-:1503: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1503: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1:
+/*

-:1552: WARNING:TYPO_SPELLING: 'similiar' may be misspelled - perhaps 'similar'?
#1552: FILE: drivers/gpu/drm/drm_atomic_uapi.c:50:
+ * for load detect or similiar.

-:1583: ERROR:CODE_INDENT: code indent should use tabs where possible
#1583: FILE: drivers/gpu/drm/drm_atomic_uapi.c:81:
+^I^I                                 sizeof(umode),$

-:1583: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1583: FILE: drivers/gpu/drm/drm_atomic_uapi.c:81:
+			drm_property_create_blob(state->crtc->dev,
+		                                 sizeof(umode),

-:1584: ERROR:CODE_INDENT: code indent should use tabs where possible
#1584: FILE: drivers/gpu/drm/drm_atomic_uapi.c:82:
+^I^I                                 &umode);$

-:1617: ERROR:CODE_INDENT: code indent should use tabs where possible
#1617: FILE: drivers/gpu/drm/drm_atomic_uapi.c:115:
+                                      struct drm_property_blob *blob)$

-:1617: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1617: FILE: drivers/gpu/drm/drm_atomic_uapi.c:115:
+                                      struct drm_property_blob *blob)$

-:1860: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1860: FILE: drivers/gpu/drm/drm_atomic_uapi.c:358:
+static int set_out_fence_for_connector(struct drm_atomic_state *state,
+					struct drm_connector *connector,

-:1900: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!new_blob"
#1900: FILE: drivers/gpu/drm/drm_atomic_uapi.c:398:
+		if (new_blob == NULL)

-:1922: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1922: FILE: drivers/gpu/drm/drm_atomic_uapi.c:420:
+static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,
+		struct drm_crtc_state *state, struct drm_property *property,

-:1930: CHECK:BRACES: braces {} should be used on all arms of this statement
#1930: FILE: drivers/gpu/drm/drm_atomic_uapi.c:428:
+	if (property == config->prop_active)
[...]
+	else if (property == config->prop_mode_id) {
[...]
+	} else if (property == config->degamma_lut_property) {
[...]
+	} else if (property == config->ctm_property) {
[...]
+	} else if (property == config->gamma_lut_property) {
[...]
+	} else if (property == config->prop_out_fence_ptr) {
[...]
+	} else if (crtc->funcs->atomic_set_property) {
[...]
+	} else {
[...]

-:1940: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1940: FILE: drivers/gpu/drm/drm_atomic_uapi.c:438:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->degamma_lut,

-:1948: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1948: FILE: drivers/gpu/drm/drm_atomic_uapi.c:446:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->ctm,

-:1956: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1956: FILE: drivers/gpu/drm/drm_atomic_uapi.c:454:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->gamma_lut,

-:1974: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1974: FILE: drivers/gpu/drm/drm_atomic_uapi.c:472:
+		return crtc->funcs->atomic_set_property(crtc, state, property, val);
+	} else {

-:1986: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1986: FILE: drivers/gpu/drm/drm_atomic_uapi.c:484:
+drm_atomic_crtc_get_property(struct drm_crtc *crtc,
+		const struct drm_crtc_state *state,

-:2013: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2013: FILE: drivers/gpu/drm/drm_atomic_uapi.c:511:
+static int drm_atomic_plane_set_property(struct drm_plane *plane,
+		struct drm_plane_state *state, struct drm_property *property,

-:2021: WARNING:LINE_SPACING: Missing a blank line after declarations
#2021: FILE: drivers/gpu/drm/drm_atomic_uapi.c:519:
+		struct drm_framebuffer *fb = drm_framebuffer_lookup(dev, NULL, val);
+		drm_atomic_set_fb_for_plane(state, fb);

-:2037: WARNING:LINE_SPACING: Missing a blank line after declarations
#2037: FILE: drivers/gpu/drm/drm_atomic_uapi.c:535:
+		struct drm_crtc *crtc = drm_crtc_find(dev, NULL, val);
+		return drm_atomic_set_crtc_for_plane(state, crtc);

-:2086: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2086: FILE: drivers/gpu/drm/drm_atomic_uapi.c:584:
+drm_atomic_plane_get_property(struct drm_plane *plane,
+		const struct drm_plane_state *state,

-:2092: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#2092: FILE: drivers/gpu/drm/drm_atomic_uapi.c:590:
+	if (property == config->prop_fb_id) {
[...]
+	} else if (property == config->prop_in_fence_fd) {
[...]
+	} else if (property == config->prop_crtc_id) {
[...]
+	} else if (property == config->prop_crtc_x) {
[...]
+	} else if (property == config->prop_crtc_y) {
[...]
+	} else if (property == config->prop_crtc_w) {
[...]
+	} else if (property == config->prop_crtc_h) {
[...]
+	} else if (property == config->prop_src_x) {
[...]
+	} else if (property == config->prop_src_y) {
[...]
+	} else if (property == config->prop_src_w) {
[...]
+	} else if (property == config->prop_src_h) {
[...]
+	} else if (property == plane->alpha_property) {
[...]
+	} else if (property == plane->blend_mode_property) {
[...]
+	} else if (property == plane->rotation_property) {
[...]
+	} else if (property == plane->zpos_property) {
[...]
+	} else if (property == plane->color_encoding_property) {
[...]
+	} else if (property == plane->color_range_property) {
[...]
+	} else if (plane->funcs->atomic_get_property) {
[...]
+	} else {
[...]

-:2147: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2147: FILE: drivers/gpu/drm/drm_atomic_uapi.c:645:
+static int drm_atomic_set_writeback_fb_for_connector(

-:2169: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2169: FILE: drivers/gpu/drm/drm_atomic_uapi.c:667:
+static int drm_atomic_connector_set_property(struct drm_connector *connector,
+		struct drm_connector_state *state, struct drm_property *property,

-:2177: WARNING:LINE_SPACING: Missing a blank line after declarations
#2177: FILE: drivers/gpu/drm/drm_atomic_uapi.c:675:
+		struct drm_crtc *crtc = drm_crtc_find(dev, NULL, val);
+		return drm_atomic_set_crtc_for_connector(state, crtc);

-:2237: WARNING:LINE_SPACING: Missing a blank line after declarations
#2237: FILE: drivers/gpu/drm/drm_atomic_uapi.c:735:
+		int ret = drm_atomic_set_writeback_fb_for_connector(state, fb);
+		if (fb)

-:2260: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2260: FILE: drivers/gpu/drm/drm_atomic_uapi.c:758:
+drm_atomic_connector_get_property(struct drm_connector *connector,
+		const struct drm_connector_state *state,

-:2320: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2320: FILE: drivers/gpu/drm/drm_atomic_uapi.c:818:
+int drm_atomic_get_property(struct drm_mode_object *obj,
+		struct drm_property *property, uint64_t *val)

-:2328: WARNING:LINE_SPACING: Missing a blank line after declarations
#2328: FILE: drivers/gpu/drm/drm_atomic_uapi.c:826:
+		struct drm_connector *connector = obj_to_connector(obj);
+		WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));

-:2330: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2330: FILE: drivers/gpu/drm/drm_atomic_uapi.c:828:
+		ret = drm_atomic_connector_get_property(connector,
+				connector->state, property, val);

-:2335: WARNING:LINE_SPACING: Missing a blank line after declarations
#2335: FILE: drivers/gpu/drm/drm_atomic_uapi.c:833:
+		struct drm_crtc *crtc = obj_to_crtc(obj);
+		WARN_ON(!drm_modeset_is_locked(&crtc->mutex));

-:2337: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2337: FILE: drivers/gpu/drm/drm_atomic_uapi.c:835:
+		ret = drm_atomic_crtc_get_property(crtc,
+				crtc->state, property, val);

-:2342: WARNING:LINE_SPACING: Missing a blank line after declarations
#2342: FILE: drivers/gpu/drm/drm_atomic_uapi.c:840:
+		struct drm_plane *plane = obj_to_plane(obj);
+		WARN_ON(!drm_modeset_is_locked(&plane->mutex));

-:2344: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2344: FILE: drivers/gpu/drm/drm_atomic_uapi.c:842:
+		ret = drm_atomic_plane_get_property(plane,
+				plane->state, property, val);

-:2359: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2359: FILE: drivers/gpu/drm/drm_atomic_uapi.c:857:
+static struct drm_pending_vblank_event *create_vblank_event(

-:2364: WARNING:SIZEOF_PARENTHESIS: sizeof *e should be sizeof(*e)
#2364: FILE: drivers/gpu/drm/drm_atomic_uapi.c:862:
+	e = kzalloc(sizeof *e, GFP_KERNEL);

-:2449: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2449: FILE: drivers/gpu/drm/drm_atomic_uapi.c:947:
+		ret = drm_atomic_connector_set_property(connector,
+				connector_state, prop, prop_value);

-:2463: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2463: FILE: drivers/gpu/drm/drm_atomic_uapi.c:961:
+		ret = drm_atomic_crtc_set_property(crtc,
+				crtc_state, prop, prop_value);

-:2477: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2477: FILE: drivers/gpu/drm/drm_atomic_uapi.c:975:
+		ret = drm_atomic_plane_set_property(plane,
+				plane_state, prop, prop_value);

-:2493: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
#2493: FILE: drivers/gpu/drm/drm_atomic_uapi.c:991:
+ * between devices. A Fence or a group of fences are transfered to/from

-:2565: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2565: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1063:
+static int prepare_signaling(struct drm_device *dev,
+				  struct drm_atomic_state *state,

-:2772: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2772: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1270:
+	if ((arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) &&
+			!dev->mode_config.async_page_flip)

-:2777: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2777: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1275:
+	if ((arg->flags & DRM_MODE_ATOMIC_TEST_ONLY) &&
+			(arg->flags & DRM_MODE_PAGE_FLIP_EVENT))

-:3049: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#3049: FILE: include/drm/drm_atomic_uapi.h:1:
+/*

-:3106: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 3 errors, 17 warnings, 25 checks, 2443 lines checked
a0725c65f9ee drm/atomic-helper: Unexport drm_atomic_helper_best_encoder
-:133: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 72 lines checked
743e2645a0a1 drm/amdgpu: Remove default best_encoder hook from DC
-:58: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 35 lines checked
e8bab7fce24b drm: Update todo.rst
0cac37810f9d drm: Extract drm_atomic_state_helper.[hc]
-:640: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#640: 
new file mode 100644

-:645: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#645: FILE: drivers/gpu/drm/drm_atomic_state_helper.c:1:
+/*

-:959: WARNING:TYPO_SPELLING: 'conector' may be misspelled - perhaps 'connector'?
#959: FILE: drivers/gpu/drm/drm_atomic_state_helper.c:315:
+ * the &drm_conector->state pointer of @connector, usually required when

-:1007: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1007: FILE: drivers/gpu/drm/drm_atomic_state_helper.c:363:
+__drm_atomic_helper_connector_duplicate_state(struct drm_connector *connector,
+					    struct drm_connector_state *state)

-:1157: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1157: FILE: drivers/gpu/drm/drm_atomic_state_helper.c:513:
+void drm_atomic_helper_connector_destroy_state(struct drm_connector *connector,
+					  struct drm_connector_state *state)

-:1316: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1316: FILE: include/drm/drm_atomic_state_helper.h:1:
+/*

-:1373: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1373: FILE: include/drm/drm_atomic_state_helper.h:58:
+void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
+					  struct drm_plane_state *state);

-:1380: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1380: FILE: include/drm/drm_atomic_state_helper.h:65:
+__drm_atomic_helper_connector_duplicate_state(struct drm_connector *connector,
+					   struct drm_connector_state *state);

-:1389: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1389: FILE: include/drm/drm_atomic_state_helper.h:74:
+void drm_atomic_helper_connector_destroy_state(struct drm_connector *connector,
+					  struct drm_connector_state *state);

-:1395: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 5 warnings, 5 checks, 784 lines checked
3f52631f306e drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property
a00d9f872f7f drm/vmwgfx: Don't look at state->allow_modeset
835a147156e8 drm/atomic: Improve docs for drm_atomic_state->allow_modeset
-:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 22 lines checked
64895f7efd90 drm/vmwgfx: Add FIXME comments for customer page_flip handlers
-:58: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 21 lines checked



More information about the Intel-gfx mailing list