[Intel-gfx] [PATCH 14/14] drm/vmwgfx: Add FIXME comments for customer page_flip handlers

[Daniel Vetter]

On Tue, Sep 4, 2018 at 3:45 PM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> On 09/03/2018 06:54 PM, Daniel Vetter wrote:
>>
>> The idea behind allowing drivers to override legacy ioctls (instead of
>> using the generic implementations unconditionally) is to handle bugs
>> in old driver-specific userspace. Like e.g. vmw_kms_set_config does,
>> to work around some vmwgfx userspace not clearing its ioctl structs
>> properly.
>>
>> But you can't use it to augment semantics and put in additional
>> checks, since from a correctly working userspace's pov there should
>> not be any difference in behaviour between the legacy and the atomic
>> paths.
>>
>> vmwgfx seems to be doing some strange things in its page_flip
>> handlers. Since I'm not an expert of this codebase just wrap some
>> FIXME comments around the potentially problematic code.
>>
> Thanks for the patch, Daniel
>
> Your comments seem valid. We'll try to fix this internally before the next
> merge window rather than to add the FIXMEs

Sounds all good to me. And if you have questions I'm happy to help out
(and use that generally as an opportunity to improve the docs).

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch