[Intel-gfx] [PATCH] drm/i915: Add AML id into KBL_ULX support list

Souza, Jose jose.souza at intel.com
Fri Sep 21 17:46:43 UTC 2018


On Fri, 2018-09-21 at 09:17 -0700, Lee, Shawn C wrote:
> According to patch "drm/i915/aml: Introducing Amber Lake platform"
> (e364672477a1). Amber Lake uses the same gen graphics as Kaby Lake.
> And it is the member of KBL ULX series.
> 
> So far, IS_KBL_ULX macro did not include AML platform. It may caused
> driver load DDI translation table for KBL H/S series for AML system.
> The change will lead driver to apply translation table for KBL Y for
> AML device to avoid unexpected eDP/DP signal quality issue.
> 
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Jose Roberto de Souza <jose.souza at intel.com>
> Signed-off-by: Lee, Shawn C <shawn.c.lee at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h
> index 808204a7ca7c..0388de4d64a2 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2460,7 +2460,9 @@ intel_info(const struct drm_i915_private
> *dev_priv)
>  				 INTEL_DEVID(dev_priv) == 0x5926)
>  #define IS_KBL_ULX(dev_priv)	(INTEL_DEVID(dev_priv) == 0x590E || \
>  				 INTEL_DEVID(dev_priv) == 0x5915 || \
> -				 INTEL_DEVID(dev_priv) == 0x591E)
> +				 INTEL_DEVID(dev_priv) == 0x591E || \
> +				 INTEL_DEVID(dev_priv) == 0x591C || \
> +				 INTEL_DEVID(dev_priv) == 0x87C0)

I guess we should keep the AML/WHL pattern, so could you create
IS_AML_ULX() add AML IDs and then include add IS_AML_ULX() to
IS_KBL_ULX()?

>  #define IS_SKL_GT2(dev_priv)	(IS_SKYLAKE(dev_priv) && \
>  				 (dev_priv)->info.gt == 2)
>  #define IS_SKL_GT3(dev_priv)	(IS_SKYLAKE(dev_priv) && \


More information about the Intel-gfx mailing list