[Intel-gfx] [PATCH 2/4] drm/i915: Introduce struct hpd_irq_regs

Chris Wilson chris at chris-wilson.co.uk
Mon Apr 15 16:45:16 UTC 2019

Quoting Ville Syrjala (2019-04-15 16:49:02)
>  static void ibx_irq_handler(struct drm_i915_private *dev_priv, u32 pch_iir)
>  {
> +       struct hpd_irq_regs hpd = {};

Is unnecessary, right?

hpd.hotplug_trigger is set here, and .dig_hotplug_reg immediately after
by irq_ack.

So other than those extra clears, it looks straightforward enough.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

More information about the Intel-gfx mailing list