[Intel-gfx] [PATCH i-g-t 3/3] lib/igt_dummyload: Send batch as first

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 23 14:58:43 UTC 2019


Quoting Mika Kuoppala (2019-04-23 15:00:38)
> @@ -41,8 +42,13 @@ typedef struct igt_spin {
>         uint32_t cmd_precondition;
>  
>         int out_fence;
> -       struct drm_i915_gem_exec_object2 obj[2];
> +
> +       struct drm_i915_gem_exec_object2 _obj[3];
> +#define SPIN_OBJ_BATCH 0
> +#define SPIN_OBJ_POLL  1
> +#define SPIN_OBJ_DEP   2

I don't see the purpose in _obj[] if we keep on using it directly. Can
you please split this into a separate patch (the introduction of the
named indices and conversion of callers, but keep spin->obj[]).

If you have reason later to hide spin->obj[], by all means do introduce
spin->__obj[] with the helpers to hide it.
-Chris


More information about the Intel-gfx mailing list