[Intel-gfx] [PATCH 07/32] drm/i915: Move GraphicsTechnology files under gt/

Rodrigo Vivi rodrigo.vivi at intel.com
Tue Apr 23 16:46:39 UTC 2019


On Tue, Apr 23, 2019 at 12:40:10PM +0300, Jani Nikula wrote:
> 
> I'll want two things:
> 
> * Explicit ack from Rodrigo too


Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

(sorry for being late here)

> 
> * The dependencies merged first, and this one posted as a single
>   patch. I really want this to stand out better, instead of semi-hidden
>   in the middle of a 30+ patch series.

+1.

> 
> 
> Acked-by: Jani Nikula <jani.nikula at intel.com>
> 
> 
> On Tue, 23 Apr 2019, Joonas Lahtinen <joonas.lahtinen at linux.intel.com> wrote:
> > Quoting Joonas Lahtinen (2019-04-18 15:04:49)
> >> + Jani and Rodrigo to comment
> >
> > No objection here and drm-intel-next was freshly tagged, so this is:
> >
> > Acked-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> >
> > Regards, Joonas
> >
> >> 
> >> I'm definitely all for doing this, so it's only a matter of the timing.
> >> 
> >> Question is, do we want to do it right now after last drm-intel-next was
> >> tagged, or do we want to wait a couple of release candidates.
> >> 
> >> I'm leaning towards doing this ASAP, as git cherry-pick should
> >> understand that they're just renames, so there should be no issue with
> >> doing the -fixes.
> >> 
> >> Regards, Joonas
> >> 
> >> Quoting Chris Wilson (2019-04-17 10:56:32)
> >> > Start partitioning off the code that talks to the hardware (GT) from the
> >> > uapi layers and move the device facing code under gt/
> >> > 
> >> > One casualty is s/intel_ringbuffer.h/intel_engine.h/ with the plan to
> >> > subdivide that header and body further (and split out the submission
> >> > code from the ringbuffer and logical context handling). This patch aims
> >> > to be simple motion so git can fixup inflight patches with little mess.
> >> > 
> >> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list