[Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 16 09:40:06 UTC 2019


Quoting Jani Nikula (2019-08-16 10:35:08)
> On Thu, 15 Aug 2019, Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com> wrote:
> > @@ -1622,7 +1560,7 @@ struct drm_i915_private {
> >       u32 suspend_count;
> >       bool power_domains_suspended;
> >       struct i915_suspend_saved_registers regfile;
> > -     struct vlv_s0ix_state vlv_s0ix_state;
> > +     void *s0ix_state;
> 
> I'd keep the vlv_ prefix in the member name.

And forward decl to avoid a naked void *
-Chris


More information about the Intel-gfx mailing list