[Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

[Jani Nikula]

On Fri, 16 Aug 2019, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-08-16 10:35:08)
>> On Thu, 15 Aug 2019, Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com> wrote:
>> > @@ -1622,7 +1560,7 @@ struct drm_i915_private {
>> >       u32 suspend_count;
>> >       bool power_domains_suspended;
>> >       struct i915_suspend_saved_registers regfile;
>> > -     struct vlv_s0ix_state vlv_s0ix_state;
>> > +     void *s0ix_state;
>> 
>> I'd keep the vlv_ prefix in the member name.
>
> And forward decl to avoid a naked void *

Oh yes absolutely, I had that in my version of the patch, and didn't
even spot it here!

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center