[Intel-gfx] [PATCH v3 11/13] drm/i915/dsi: use compressed pixel format with DSC

[Kulkarni, Vandita]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at intel.com>
> Sent: Tuesday, November 26, 2019 7:13 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula at intel.com>; Kulkarni, Vandita
> <vandita.kulkarni at intel.com>; Ville Syrjälä <ville.syrjala at linux.intel.com>
> Subject: [PATCH v3 11/13] drm/i915/dsi: use compressed pixel format with
> DSC
> 
> When compression is enabled, configure the DSI transcoder to use
> compressed format.
> 
> Suggested-by: Vandita Kulkarni <vandita.kulkarni at intel.com>
> Cc: Vandita Kulkarni <vandita.kulkarni at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Looks good to me.
Reviewed-by: Vandita Kulkarni <vandita.kulkarni at intel.com>

Regards,
Vandita
> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 36 ++++++++++++++------------
>  1 file changed, 20 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
> b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 5149a28a874b..460759913708 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -682,22 +682,26 @@ gen11_dsi_configure_transcoder(struct
> intel_encoder *encoder,
> 
>  		/* select pixel format */
>  		tmp &= ~PIX_FMT_MASK;
> -		switch (intel_dsi->pixel_format) {
> -		default:
> -			MISSING_CASE(intel_dsi->pixel_format);
> -			/* fallthrough */
> -		case MIPI_DSI_FMT_RGB565:
> -			tmp |= PIX_FMT_RGB565;
> -			break;
> -		case MIPI_DSI_FMT_RGB666_PACKED:
> -			tmp |= PIX_FMT_RGB666_PACKED;
> -			break;
> -		case MIPI_DSI_FMT_RGB666:
> -			tmp |= PIX_FMT_RGB666_LOOSE;
> -			break;
> -		case MIPI_DSI_FMT_RGB888:
> -			tmp |= PIX_FMT_RGB888;
> -			break;
> +		if (pipe_config->dsc.compression_enable) {
> +			tmp |= PIX_FMT_COMPRESSED;
> +		} else {
> +			switch (intel_dsi->pixel_format) {
> +			default:
> +				MISSING_CASE(intel_dsi->pixel_format);
> +				/* fallthrough */
> +			case MIPI_DSI_FMT_RGB565:
> +				tmp |= PIX_FMT_RGB565;
> +				break;
> +			case MIPI_DSI_FMT_RGB666_PACKED:
> +				tmp |= PIX_FMT_RGB666_PACKED;
> +				break;
> +			case MIPI_DSI_FMT_RGB666:
> +				tmp |= PIX_FMT_RGB666_LOOSE;
> +				break;
> +			case MIPI_DSI_FMT_RGB888:
> +				tmp |= PIX_FMT_RGB888;
> +				break;
> +			}
>  		}
> 
>  		if (INTEL_GEN(dev_priv) >= 12) {
> --
> 2.20.1