[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Drop unnecessary struct_mutex around i915_reset()

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri Feb 15 15:21:11 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Since we no longer need to hold struct_mutex to perform a global device
> reset, don't do so for igt_reset_wedge().
>

Oh but the interesting question is not about need, but should =)
Do it both ways?

-Mika

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> index f75cb56ff8ad..57e02840be9e 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> @@ -399,10 +399,8 @@ static int igt_wedged_reset(void *arg)
>  
>  	i915_gem_set_wedged(i915);
>  
> -	mutex_lock(&i915->drm.struct_mutex);
>  	GEM_BUG_ON(!i915_terminally_wedged(&i915->gpu_error));
>  	i915_reset(i915, ALL_ENGINES, NULL);
> -	mutex_unlock(&i915->drm.struct_mutex);
>  
>  	intel_runtime_pm_put(i915, wakeref);
>  	igt_global_reset_unlock(i915);
> -- 
> 2.20.1


More information about the Intel-gfx mailing list