[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Drop unnecessary struct_mutex around i915_reset()

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 15 15:28:55 UTC 2019


Quoting Mika Kuoppala (2019-02-15 15:21:11)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Since we no longer need to hold struct_mutex to perform a global device
> > reset, don't do so for igt_reset_wedge().
> >
> 
> Oh but the interesting question is not about need, but should =)
> Do it both ways?

Just doing it without should be enough for lockdep, and specifically
remember to guard everything with lockdep_assert_held() when required.
The reverse case of testing with it held can only prove a deadlock by
hitting it! (At which point CI reboots the machine.)
-Chris


More information about the Intel-gfx mailing list