[Intel-gfx] [PATCH v2 0/5] drm/i915: Rename functions to match their entry points

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 11 07:40:02 UTC 2019


Quoting Janusz Krzysztofik (2019-07-11 08:31:52)
> Need for this was identified while working on split of driver unbind
> path into _remove() and _release() parts.  Consistency in function
> naming has been recognized as helpful when trying to work out which
> phase the code is in.
> 
> v2: * early_probe pairs better with late_release (Chris),
>     * exclude patch 6/6 "drm/i915: Rename "inject_load_failure" module
>       parameter" for now, it requires updates on user (IGT) side
>     * rebase on top of "drm/i915: Drop extern qualifiers from header
>       function prototypes"
> 
> Janusz Krzysztofik (5):
>   drm/i915: Rename "_load"/"_unload" to match PCI entry points
>   drm/i915: Replace "_load" with "_probe" consequently
>   drm/i915: Propagate "_release" function name suffix down
>   drm/i915: Propagate "_remove" function name suffix down
>   drm/i915: Propagate "_probe" function name suffix down

I'm happy with the chosen names and my main concern is for improving
consistency for ease of discoverability, so

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

A few of the usual suspects should chime in as well...
-Chris


More information about the Intel-gfx mailing list